Axes panel visibility issues #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmt0
force-pushed
the
axes-panel-visibility-issues
branch
from
f49f31a to
e5f1f23
Compare
Contributor
|
💃 |
src/default_panels/StyleAxesPanel.js
Outdated
| name={_('Hover Projections')} | ||
| axisFilter={axis => | ||
| !axis._name.includes('angular') && !axis._name.includes('radial') | ||
| !axis._name.includes('angular') && |
Contributor
There was a problem hiding this comment.
is it possible to have angular in a cartesian subplot? I don't think so... so we can get rid of the first two checks here no?
src/default_panels/StyleAxesPanel.js
Outdated
| axisFilter={axis => | ||
| !axis._name.includes('radial') && !axis._name.includes('angular') | ||
| !( | ||
| axis._name.includes('radial') || |
Contributor
There was a problem hiding this comment.
here can we not do something like _subplot.includes('polar') or something?
dmt0
force-pushed
the
axes-panel-visibility-issues
branch
2 times, most recently
from
7a72aa0 to
d4ae302
Compare
Contributor
|
According to Percy we've just lost the Hover Projections fold for a cartesian set of axes... can you look into that plz? |
Contributor
Author
|
Yep, because subplot is not 'cartesian', but 'xaxis' or 'yaxis' |
Contributor
|
Ah, ok, then that logic needs changing :) |
dmt0
force-pushed
the
axes-panel-visibility-issues
branch
from
d4ae302 to
95891a6
Compare
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #473